Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added "enabled" field to decision metadata structure #275

Merged
merged 3 commits into from
Nov 13, 2020
Merged

feat: added "enabled" field to decision metadata structure #275

merged 3 commits into from
Nov 13, 2020

Conversation

zashraf1985
Copy link
Contributor

Summary

  1. Added "enabled" field to decision metadata structure
  2. Setting "enabled" to true for activate() since we check for non nil variation.

Test Plan

  1. Manuall tested thoroughly
  2. Fixed existing unit tests

@zashraf1985 zashraf1985 requested a review from a team as a code owner November 10, 2020 00:27
@coveralls
Copy link

coveralls commented Nov 10, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.0001%) to 99.587% when pulling 1de2c13 on zeeshan/flag_decisions_fix into b97c41e on master.

@zashraf1985 zashraf1985 removed their assignment Nov 10, 2020
Mat001
Mat001 reviewed Nov 13, 2020
View reviewed changes
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pawels-optimizely
pawels-optimizely reviewed Nov 13, 2020
View reviewed changes
lib/optimizely.rb Outdated
@@ -142,7 +142,7 @@ def activate(experiment_key, user_id, attributes = nil)
experiment = config.get_experiment_from_key(experiment_key)
send_impression(
config, experiment, variation_key, '', experiment_key,
Optimizely::DecisionService::DECISION_SOURCES['EXPERIMENT'], user_id, attributes
Optimizely::DecisionService::DECISION_SOURCES['EXPERIMENT'], user_id, true, attributes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add this parameter after experiment key ? I think adding that between user_id and attributes is a wrong place

@pawels-optimizely pawels-optimizely merged commit 73fdcf6 into master Nov 13, 2020
@pawels-optimizely pawels-optimizely deleted the zeeshan/flag_decisions_fix branch November 13, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mat001 Mat001 Mat001 left review comments

@pawels-optimizely pawels-optimizely pawels-optimizely approved these changes

Assignees
No one assigned
Labels
🤖 24 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zashraf1985 @coveralls @Mat001 @pawels-optimizely @optimizely-codereview-bot