[FSSDK-9509] Update http_project_config_manager.rb with soft log warning about polling interval < 30s #338

Mat001 · 2023-09-25T17:23:01Z

Add soft warning that polling interval under 30 s is not recommended.

Summary

To synchronize with ter SDKs. Peloton had an issue with setting polling interval too low. So we are adding this soft warning to all SDKs including Ruby.
See Jira ticket below for more.

Unit tests

Add soft warning that polling interval under 30 s is not recommended.

lib/optimizely/config_manager/http_project_config_manager.rb

Co-authored-by: Andy Leap <[email protected]>

andrewleap-optimizely

lgtm

Update http_project_config_manager.rb

49bdc1c

Add soft warning that polling interval under 30 s is not recommended.

Mat001 requested a review from a team as a code owner September 25, 2023 17:23

optimizely-codereview-bot assigned Mat001 Sep 25, 2023

Mat001 added 3 commits September 25, 2023 10:29

Update w single quotes

53fffd0

Update http_project_config_manager.rb

703b19f

Update WARNING to WARN

cd2228d

Mat001 requested a review from andrewleap-optimizely September 25, 2023 17:52

andrewleap-optimizely suggested changes Sep 25, 2023

View reviewed changes

lib/optimizely/config_manager/http_project_config_manager.rb Outdated Show resolved Hide resolved

Update lib/optimizely/config_manager/http_project_config_manager.rb

7975e9d

Co-authored-by: Andy Leap <[email protected]>

andrewleap-optimizely approved these changes Sep 25, 2023

View reviewed changes

Mat001 merged commit 85512a2 into master Sep 25, 2023
9 checks passed

Mat001 deleted the mpirnovar-soft-warning branch September 25, 2023 20:47