Remove non JSON logging when JSON variable is true #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dont add non json log. Makes jq easier.
hashmap
reviewed
Mar 7, 2018
main.go
Outdated
| @@ -57,7 +57,9 @@ func main() { | |||
| if err != nil { | |||
| fmt.Fprintf(os.Stderr, "Failed to analyze using API v%d: %s\n", ver, err) | |||
| } else { | |||
| fmt.Printf("Got results from Clair API v%d\n", ver) | |||
| if conf.JSONOutput == false { | |||
There was a problem hiding this comment.
I think !conf.JSONOutput is more idiomatic
There was a problem hiding this comment.
okay, will change. I'm new to go so...
|
@hashmap gladly. |
|
Thanks for great work |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When JSON_OUTPUT var is true, its nice to only output json for a successful scan so I can be parsed or piped to jq