Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unittests for aqua.evaluation/finetuning and handlers(evaluation/common/base) #763

Merged
merged 20 commits into from
Apr 12, 2024
Merged

Unittests for aqua.evaluation/finetuning and handlers(evaluation/common/base) #763

merged 20 commits into from
Apr 12, 2024

Conversation

mingkang111
Copy link
Member

@mingkang111 mingkang111 commented Apr 9, 2024 •
edited
Loading

PR contains unittest for aqua.evaluation, aqua.finetuning, evaluation handler, common handler, and base handler.

Coverage

Screenshot 2024-04-12 at 12 53 59

This PR also includes @lu-ohai 's contribution on create evaluation and FT.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 9, 2024
@mingkang111 mingkang111 mentioned this pull request Apr 9, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

📌 Cov diff with main:

Coverage-0%

📌 Overall coverage:

Coverage-21.38%

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

📌 Cov diff with main:

Coverage-100%

📌 Overall coverage:

Coverage-60.03%

mayoor
mayoor reviewed Apr 9, 2024
View reviewed changes
ads/aqua/evaluation.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mingkang111 , could you please reset this file to what is in main? I understand that it is only comments and formatting. But Would like only change to tests folder to the master before we make changes to any code of any kind.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@mingkang111 mingkang111 requested a review from mayoor April 9, 2024 16:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

📌 Cov diff with main:

No lines with coverage information in this diff.

📌 Overall coverage:

Coverage-60.03%

@lu-ohai
Copy link
Member

lu-ohai commented Apr 10, 2024 •
edited
Loading

Just added the unit tests for create evaluation and fine tuning to this branch.
Screenshot 2024-04-10 at 2 18 01 PM
Screenshot 2024-04-10 at 2 24 57 PM

@lu-ohai lu-ohai changed the title Unittest for aqua.evaluation Unittest for aqua.evaluation/Finetuning Apr 10, 2024
@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

No lines with coverage information in this diff.

📌 Overall coverage:

Coverage-60.35%

VipulMascarenhas
VipulMascarenhas previously approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@VipulMascarenhas VipulMascarenhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

mayoor
mayoor previously approved these changes Apr 11, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

No lines with coverage information in this diff.

📌 Overall coverage:

Coverage-60.36%

mrDzurb
mrDzurb previously approved these changes Apr 11, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

No lines with coverage information in this diff.

📌 Overall coverage:

Coverage-60.32%

@mingkang111 mingkang111 changed the title Unittest for aqua.evaluation/Finetuning Unittests for aqua.evaluation/finetuning and handlers(evaluation/common/base) Apr 12, 2024
@mingkang111
Copy link
Member Author

As per @VipulMascarenhas request, merging PR #773 for handler test into this PR.

@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

No lines with coverage information in this diff.

📌 Overall coverage:

Coverage-60.45%

mrDzurb
mrDzurb previously approved these changes Apr 12, 2024
View reviewed changes
@mingkang111
Copy link
Member Author

The failing operation test picking up ray==2.3.0 which is incompatible with pydantic==2.7.0. Based on ray's repo ray-project/ray#37019 (comment) , ray is required to >=2.5 to be compatible with pydantic>=2. Therefore, we can remove the pydantic as test dependency for now and implement the checking by ourselves. Once ray can be installed with > 2.5, we go back to use pydantic again.
cc: @ahosler

@github-actions GitHub Actions
Copy link

📌 Cov diff with main:

No lines with coverage information in this diff.

📌 Overall coverage:

Coverage-60.48%

@mingkang111 mingkang111 enabled auto-merge (squash) April 12, 2024 20:11
@mingkang111 mingkang111 merged commit a98df6b into main Apr 12, 2024
14 checks passed
@mingkang111 mingkang111 deleted the ming/aqua_test_2 branch April 14, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayoor mayoor mayoor approved these changes

@VipulMascarenhas VipulMascarenhas VipulMascarenhas approved these changes

@qiuosier qiuosier Awaiting requested review from qiuosier qiuosier is a code owner

@lu-ohai lu-ohai Awaiting requested review from lu-ohai

@liudmylaru liudmylaru Awaiting requested review from liudmylaru

@darenr darenr Awaiting requested review from darenr darenr is a code owner

@mrDzurb mrDzurb Awaiting requested review from mrDzurb mrDzurb is a code owner

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mingkang111 @lu-ohai @mayoor @mrDzurb @VipulMascarenhas @ahosler