Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable unused modules #159

Merged
merged 4 commits into from
May 21, 2024
Merged

Disable unused modules #159

merged 4 commits into from
May 21, 2024

Conversation

Achal1607
Copy link
Member

This PR aims to disable some obvious unused modules to reduce the size of the extension. After disabling all these modules the size of the extension reduces to almost 137 MB from almost 154 MB.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 15, 2024
arvindaprameya
arvindaprameya previously approved these changes May 15, 2024
Copy link
Member

@arvindaprameya arvindaprameya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this will help with the reduction in the size of the extension

lahodaj
lahodaj previously approved these changes May 20, 2024
Copy link
Member

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall OK, I think. One note for the dark laf inline.

nbcode/nbproject/platform.properties Outdated Show resolved Hide resolved
Copy link
Member

@arvindaprameya arvindaprameya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Member

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@Achal1607 Achal1607 merged commit 6b98feb into oracle:main May 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants