Performance tests #179
Closed
Performance tests #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Achal1607
force-pushed
the
performance-tests
branch
from
afbafa3
to
caee6e5
Compare
…he Explorer panel for non-workspace opened Java files
Fixed runConfiguration.ts: `initializeRunConfiguration()` to search for java files in open editors when no workspace is open.
1. Checked for non-workspace opened files by testing the validity of `vscode.workspace.name` AND `vscode.workspace.workspaceFile`.
2. Searched for java extension file names in `vscode.workspace.textDocuments` when no workspace is open.
3. Fixed `RunConfigurationNode.setValue()` to invoke `WorkspaceConfiguration.update()` with `configurationTarget =` :
- `true`: when no workspace is open i.e. user global target;
- `null`: otherwise i.e. workspace target.
Fixes oracle#196
Signed-off-by: Siddharth Srinivasan <[email protected]>
Upgrade node-jsonc-parser library
* pre-commit hook to check internal artifactory url * updated regex * updated regex
…rkspace [JAVAVSCODE oracle#196] Run Configuration section is unavailable in the Explorer panel for non-workspace opened Java files
* Upgrade Gradle tooling to Support JDK-22 * updated build.xml * added one more patch to support upgrade of gradle
…g options in global settings for non-workspace opened Java files (oracle#211) Fixed extension.ts `UpdateConfigurationRequest` handler to update the global `WorkspaceConfiguration` for non-workspace opened files. 1. Checked for non-workspace opened files by testing if `vscode.workspace.workspaceFile` is undefined/null. 2. Invoked `WorkspaceConfiguration.update()` with `configurationTarget = `: - `true`: for non-workspace files; - `null`: otherwise. 3. Added a try-catch to log errors in update and prevent downstream failures. 4. Avoided an unnecessary `await` and used the `Thenable` chain of `update()`. Fixes oracle#199 Signed-off-by: Siddharth Srinivasan <[email protected]>
* backporting NetBeans 23 fixes * updated patch name * updated 7548 patch
1. Placed patch files in separate lines to ease merges and reduce conflicts.
2. Added string parsing and trimming of the patches list to allow for placing patch files in separate lines.
- Also added a check for empty patch list when applying or unapplying the patches.
3. Added a "clean-netbeans" target, similar to the "build-netbeans" target, to help in cleaning just the netbeans build artifacts.
Signed-off-by: Siddharth Srinivasan <[email protected]>
…-cleanup Ant build script reorganization for patches and clean-netbeans
Bump up axios to latest(1.7.3)
* Updated README added Enabling Java preview features section
* [JVSC oracle#199] Backport NetBeans 24 patch 7610 Backporting the NetBeans 24 patch [#7610](apache/netbeans#7610) and adding it to the patches list in build.xml. - This brings the fix for getting config options for a single source file to the NB 22 branch. - This allows the fix for oracle#199 to demonstrate its effect. Signed-off-by: Siddharth Srinivasan <[email protected]> * Update build.xml with ascending numeric order of PR patches Signed-off-by: Siddharth Srinivasan <[email protected]> --------- Signed-off-by: Siddharth Srinivasan <[email protected]>
…doesn't support {@return foo} (oracle#237)
Signed-off-by: Subhash Arabhi <[email protected]> Co-authored-by: Siddharth Srinivasan <[email protected]>
Bump up axios to 1.7.4
sid-srini
requested changes
Aug 20, 2024
| }).timeout(10000); | ||
|
|
||
| test("Performance test on OpenJDK repository", async () => { | ||
| const args = ["--depth", 1, "--branch", "jdk-23+25"]; |
There was a problem hiding this comment.
Perhaps set the branch value to master so that it is always available.
The currently given branch is no longer present.
|
|
||
| await checkIfIndexingCompleted(); | ||
| const endTime = Date.now() - startTime; | ||
| console.log("END_TIME: " + endTime); |
There was a problem hiding this comment.
Perhaps rename END_TIME to TIME_TAKEN.
|
|
||
| const checkExtensionLoaded = (path: string): boolean => { | ||
| let d = languages.getDiagnostics(Uri.file(path)); | ||
| return d.length != 0; |
There was a problem hiding this comment.
Do add a comment on constants.OPENJDK_CHECK_FILES_RESOLVES that the files chosen must have some warnings or other diagnostic information/hints generated. Otherwise, this method would fail to detect that the extension loaded.
| let d = languages.getDiagnostics(Uri.file(path)); | ||
| const filterErrorsList = d.filter(el => el.severity == 0); | ||
| console.log("Filtered Errors List Length: " + filterErrorsList.length); | ||
| return filterErrorsList.length == 0; |
There was a problem hiding this comment.
Perhaps the return should check that there are some diagnostics available and then no errors are reported.
return d.length > 0 && filterErrorsList.length == 0;For the first file, this would be done by the separate invocation of checkExtensionLoaded and so it may not have any impact when there is only a single file in the check list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a starting step added performance tests to measure how much time it takes to open OpenJDK project.