Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for delete cache error on windows #245

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Conversation

shivam71
Copy link
Member

Killed the nb process and the stopped the LSP client so that no process is using the cache before deleting the directory .
Closed #221

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 26, 2024
vscode/src/extension.ts Outdated Show resolved Hide resolved
vscode/src/extension.ts Outdated Show resolved Hide resolved
vscode/src/extension.ts Outdated Show resolved Hide resolved
@shivam71
Copy link
Member Author

shivam71 commented Sep 3, 2024

Added a callback for error handling

vscode/src/extension.ts Outdated Show resolved Hide resolved
vscode/src/extension.ts Outdated Show resolved Hide resolved
@Achal1607 Achal1607 changed the base branch from main to 23.0.0 September 4, 2024 12:28
vscode/src/extension.ts Outdated Show resolved Hide resolved
vscode/src/extension.ts Outdated Show resolved Hide resolved
vscode/src/extension.ts Outdated Show resolved Hide resolved
Copy link
Member

@Achal1607 Achal1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @shivam71 for making this change

@Achal1607 Achal1607 merged commit f8979a6 into oracle:23.0.0 Sep 5, 2024
3 checks passed
subhash-arabhi pushed a commit to subhash-arabhi/javavscode that referenced this pull request Sep 11, 2024
* Fix for delete cache error on windows

* Added error handling

* Declared constant for windows os label

* Refactored code to use await and try catch pattern

* Fixed  indent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Delete Oracle Java extension cache for this workspace" fails with an error
2 participants