Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAVAVSCODE-22] Added support for using different jdk in each workspace and deprecated jdk.userdir configuration #67

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

Achal1607
Copy link
Member

  • Updated jdk.jdkhome to machine-overridable from machine so that different jdk binaries can be used in each workspace. Tested this configuration for remote SSH as well and it is working fine with it as well.
  • Deprecated jdk.userdir configuration and default behaviour is now having separate userdir for each workspace and a global userdir if no workspace is open.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 6, 2023
@Achal1607 Achal1607 linked an issue Nov 6, 2023 that may be closed by this pull request
@Achal1607 Achal1607 changed the title Added support for using different jdk in each workspace and deprecated jdk.userdir configuration [JAVAVSCODE-22] Added support for using different jdk in each workspace and deprecated jdk.userdir configuration Nov 6, 2023
Copy link
Member

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@arvindaprameya arvindaprameya merged commit 707ef2d into oracle:main Nov 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jdk.jdkhome doesn't work as documented
3 participants