[Compatibility] Accept options argument to Regexp.{new,compile} of String; Warn for unknown types
#3411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
rwstauner
changed the title
Regexp#{new,compile} of String; Warn for unknown typesRegexp.{new,compile} of String; Warn for unknown types
rwstauner
force-pushed
the
rwstauner/regexp-opts
branch
from
0e67b89
to
58dfbbb
Compare
|
CI failures seem irrelevant to the changes. |
Right, it seems related to a new ECJ in latest mx. And the workflow here just uses latest mx instead of the one specified in |
eregon
approved these changes
Jan 26, 2024
rwstauner
force-pushed
the
rwstauner/regexp-opts
branch
from
58dfbbb
to
fcac9cd
Compare
andrykonchin
approved these changes
Jan 28, 2024
andrykonchin
force-pushed
the
rwstauner/regexp-opts
branch
from
fcac9cd
to
eb54384
Compare
andrykonchin
added
the
in-ci
andrykonchin
force-pushed
the
rwstauner/regexp-opts
branch
from
eb54384
to
a2dd42b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regexp.new now supports passing the regexp flags not only as an Integer,
but also as a String. Unknown flags raise ArgumentError.
Otherwise, anything other than true, false, nil or Integer will be warned.
[Feature #18788]