Limit max encodings to 256 and raise error #3434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
thomasmarshall
force-pushed
the
jose-thomas-encoding-max-size-error
branch
from
3126bf7
to
0da1996
Compare
nirvdrum
suggested changes
Feb 2, 2024
| @@ -721,4 +721,25 @@ | |||
| str.bytes.should == [0, 0x24] | |||
| end | |||
| end | |||
|
|
|||
| describe "rb_define_dummy_encoding" do | |||
There was a problem hiding this comment.
Thank you for writing new specs!
thomasmarshall
force-pushed
the
jose-thomas-encoding-max-size-error
branch
2 times, most recently
from
298709f
to
e93e6b0
Compare
andrykonchin
reviewed
Feb 5, 2024
eregon
reviewed
Feb 5, 2024
src/main/java/org/truffleruby/core/encoding/EncodingManager.java
Outdated
Show resolved
Hide resolved
thomasmarshall
force-pushed
the
jose-thomas-encoding-max-size-error
branch
3 times, most recently
from
0e65921
to
8a405cd
Compare
andrykonchin
added
the
in-ci
andrykonchin
approved these changes
Feb 6, 2024
|
Could you please rebase on master to fix conflict in |
Co-authored-by: Jose Narvaez <[email protected]>
thomasmarshall
force-pushed
the
jose-thomas-encoding-max-size-error
branch
from
8a405cd
to
7408c34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3039.
This limits the max number of encodings when calling
rb_define_dummy_encodingand raiseEncodingErroras per Ruby issue 18949. Tests inspired by this from MRI.