feat: index referrers for image manifests #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wangxiaoxuan273 <[email protected]>
Signed-off-by: wangxiaoxuan273 <[email protected]>
shizhMSFT
approved these changes
Nov 23, 2022
| @@ -51,6 +51,10 @@ type Manifest struct { | |||
| // configuration. | |||
| Layers []distribution.Descriptor `json:"layers"` | |||
|
|
|||
| // Subject specifies the descriptor of another manifest. This value is | |||
| // used by the referrers API. | |||
| Subject *distribution.Descriptor `json:"subject,omitempty"` | |||
There was a problem hiding this comment.
Do you want to also update the Reference() function?
There was a problem hiding this comment.
added subject in Reference() and changed the verifyManifest function accordingly.
| @@ -141,3 +164,20 @@ func (ms *ocischemaManifestHandler) verifyManifest(ctx context.Context, mnfst oc | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| // indexReferrers indexes the subject of the given revision in its referrers index store. | |||
| func (ms *ocischemaManifestHandler) indexReferrers(ctx context.Context, dm *ocischema.DeserializedManifest, revision digest.Digest) error { | |||
There was a problem hiding this comment.
This is probably OK since oras/distribution is for testing purpose. It will be better if it is refactored since it duplicated with this function.
Signed-off-by: wangxiaoxuan273 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 57.18% 57.16% -0.02%
==========================================
Files 107 107
Lines 11021 11041 +20
==========================================
+ Hits 6302 6312 +10
- Misses 4011 4019 +8
- Partials 708 710 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
shizhMSFT
reviewed
Nov 25, 2022
| @@ -109,7 +118,7 @@ func (ms *ocischemaManifestHandler) verifyManifest(ctx context.Context, mnfst oc | |||
| } | |||
| } | |||
|
|
|||
| case v1.MediaTypeImageManifest: | |||
| case v1.MediaTypeImageManifest, v1.MediaTypeArtifactManifest, v1.MediaTypeImageIndex, schema2.MediaTypeManifest: | |||
There was a problem hiding this comment.
Added manifest list and schema1 manifest.
Signed-off-by: wangxiaoxuan273 <[email protected]>
shizhMSFT
reviewed
Nov 25, 2022
| @@ -118,7 +120,7 @@ func (ms *ocischemaManifestHandler) verifyManifest(ctx context.Context, mnfst oc | |||
| } | |||
| } | |||
|
|
|||
| case v1.MediaTypeImageManifest, v1.MediaTypeArtifactManifest, v1.MediaTypeImageIndex, schema2.MediaTypeManifest: | |||
| case v1.MediaTypeImageManifest, v1.MediaTypeArtifactManifest, v1.MediaTypeImageIndex, schema1.MediaTypeManifest, schema2.MediaTypeManifest, manifestlist.MediaTypeManifestList: | |||
There was a problem hiding this comment.
We should remove schema1 as it is deprecated.
Signed-off-by: wangxiaoxuan273 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 8 of issue #21
Part 1 of issue #39