Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should return empty manifest list when no referrers are found #53

Merged
merged 2 commits into from
Jan 5, 2023
Merged

fix: should return empty manifest list when no referrers are found #53

merged 2 commits into from
Jan 5, 2023

Conversation

wangxiaoxuan273
Copy link

@wangxiaoxuan273 wangxiaoxuan273 commented Jan 4, 2023

Resolves #51
Signed-off-by: wangxiaoxuan273 [email protected]

Current output:
First test case: 0 referrers are found.
Second test case: call with a manifest digest that is nonexistent in the repository, returns an empty manifest list.
image

registry/handlers/referrers.go Outdated Show resolved Hide resolved
registry/handlers/referrers.go Outdated Show resolved Hide resolved
Signed-off-by: wangxiaoxuan273 <[email protected]>
Copy link

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 2ba5caa into oras-project:main Jan 5, 2023
@wangxiaoxuan273 wangxiaoxuan273 deleted the null-fix branch January 5, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: referrers should return an empty manifest list, but it now returns null
2 participants