Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure optional subject in artifact manifest #206

Closed
Tracked by #200
shizhMSFT opened this issue Jun 27, 2022 · 1 comment
Closed
Tracked by #200

Ensure optional subject in artifact manifest #206

shizhMSFT opened this issue Jun 27, 2022 · 1 comment
Milestone
v2.0.0-rc.1

Comments

@shizhMSFT
Copy link
Contributor

shizhMSFT commented Jun 27, 2022 •
edited
Loading

Server-side issue: oras-project/distribution#9
@shizhMSFT shizhMSFT mentioned this issue Jun 27, 2022
Closed
5 tasks
@shizhMSFT shizhMSFT added this to the v2.0.0-rc.1 milestone Jun 27, 2022
@shizhMSFT shizhMSFT changed the title Ensure optional subject Ensure optional subject in artifact manifest Jun 27, 2022
@nima nima mentioned this issue Jun 30, 2022
Closed
nima added a commit to nima/oras that referenced this issue Jun 30, 2022
@nima
Remove push mandate on subject
85a6b4b 
Fixes oras-project/oras-go#206
Fixes oras-project#361
nima added a commit to nima/oras that referenced this issue Jun 30, 2022
@nima
Remove push mandate on subject
93ae0ea 
Fixes oras-project#361

Does NOT fix oras-project/oras-go#206; since this client does not use the go library.
nima added a commit to nima/oras that referenced this issue Jun 30, 2022
@nima
Remove push mandate on subject
0d4dceb 
Fixes oras-project#361

Does NOT fix oras-project/oras-go#206; since this client does not use the go library.

Signed-off-by: Nima Talebi <[email protected]>
nima added a commit to nima/oras that referenced this issue Jul 1, 2022
@nima
Remove push mandate on subject
6264e4f 
Fixes oras-project#361

Does NOT fix oras-project/oras-go#206; since this client does not use the go library.

Signed-off-by: Nima Talebi <[email protected]>
nima added a commit to nima/oras that referenced this issue Jul 1, 2022
@nima
Remove push mandate on subject
dc6896a 
Fixes oras-project#361

Does NOT fix oras-project/oras-go#206; since this client does not use the go library.

Signed-off-by: Nima Talebi <[email protected]>
@Wwwsylvia Wwwsylvia mentioned this issue Jul 1, 2022
Merged
@Wwwsylvia
Copy link
Member

Wwwsylvia commented Jul 6, 2022 •
edited
Loading

Closing as confirmed that subject can be nil. (See https://github.com/oras-project/oras-go/blob/main/pack.go#L174 and https://github.com/oras-project/oras-go/blob/main/content/graph.go#L82-L84)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0-rc.1
Development

No branches or pull requests
2 participants
@Wwwsylvia @shizhMSFT