Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade login/logout commands to oras-go v2 #366

Closed
Tracked by #369
qweeah opened this issue Apr 15, 2022 · 6 comments · Fixed by #367
Closed
Tracked by #369

Upgrade login/logout commands to oras-go v2 #366

qweeah opened this issue Apr 15, 2022 · 6 comments · Fixed by #367
Assignees
@qweeah
Milestone
v0.13.0

Comments

@qweeah
Copy link
Contributor

qweeah commented Apr 15, 2022 •
edited
Loading

Add login/logout packages for docker and general registries. Re-implement login and logout commands based on the new packages.
@qweeah
Copy link
Contributor Author

qweeah commented Apr 15, 2022

Related to #328 and #347

@qweeah qweeah mentioned this issue Apr 15, 2022
Merged
@sajayantony
Copy link
Contributor

Recommend breaking this up if possible or if not then can we describe why not in this thread.

@shizhMSFT
Copy link
Contributor

@qweeah Looks like both v0.4.0 and v2.0.0 of oras-go can exist at the same time.

require (
	oras.land/oras-go v0.4.0
	oras.land/oras-go/v2 v2.0.0-20220415135518-c34895e747dc
)

Let's split this PR / issue into 3 parts:

  1. Login / logout
  2. Push
  3. Pull

@qweeah qweeah changed the title Upgrade to oras-go v2 Upgrade login/logout commands to oras-go v2 Apr 18, 2022
@qweeah
Copy link
Contributor Author

qweeah commented Apr 18, 2022

@sajayantony @shizhMSFT I have made this issue specific for login/logout

@sajayantony
Copy link
Contributor

Currently there is also an issue for supporting certs for auth #217 - how do we make sure that v2 can support cert login as well.

Does the client have to significantly change?

@shizhMSFT
Copy link
Contributor

shizhMSFT commented Apr 18, 2022 •
edited
Loading

We can address #217 after addressing #366. The idea is simple that the client should construct a specific TLS config for the client with the specified cert. No changes are required for oras-go.

@sajayantony sajayantony mentioned this issue Apr 20, 2022
Closed
12 tasks
@shizhMSFT shizhMSFT pinned this issue Apr 21, 2022
@shizhMSFT shizhMSFT unpinned this issue May 6, 2022
@shizhMSFT shizhMSFT added this to the v0.13.0 milestone May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qweeah qweeah

Labels
None yet
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging a pull request may close this issue.

Upgrade login&logout commands to oras-go v2 qweeah/oras
3 participants
@sajayantony @qweeah @shizhMSFT