-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inspector improvement: logging console #5846
Comments
+1 today for |
We still, as of Orbeon Forms 2022.1, have two formats of actions:
#3855 covers migrating from the older format. In either case, if we log "actions", we should log the higher-level actions, not their translation into lower-level XForms actions (even though that would already be useful compared to having nothing). I think that this means that every action implementation in |
A log action should also have a name/category so that the logging console can filter on that: <xxf:log name="orbeon.actions" level="debug" value="..."/> |
Implementation possibilities:
You could imagine a lower-level approach where the entire logging system (we use slf4j/log4s) can be configured to redirect to the inspector. However, this doesn't seem easy to do and is probably too low-level. So instead, if we'd like the output to go to a log file but optionally to the inspector, we should go through our own higher-level system. |
|
One issue with Solutions:
So solution 1 is probably the way to go. The event buffer could have a certain limit, and be cleared as soon as the UI is ready or they are consumed, whichever comes first. |
Originally a comment on #5799.
Ideas:
<xf:message>
to write to inspector console and/or JavaScript consoletrace
actionsHow would we tell
<xf:message>
to target the inspector console? Options:level="xxf:inspector"
level=""xxf:inspector-debug
xxf:log-debug
, etc.level="xxf:log-info" xxf:log-target="inspector"
xxf:log-target="inspector"
inheritableI think it would be good to separate:
We could have:
level="xxf:debug"
:xxf:log-debug
xxf:log-target="logger|inspector|javascript-console"
Alternatively, we could introduce:
Does it make sense to split message/log? Maybe! Also,
xxf:log
would be shorter.The text was updated successfully, but these errors were encountered: