Added AVT support to navindex attribute #2130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, I plan to review the changes. |
ebruchez
force-pushed
the
master
branch
3 times, most recently
from
62217d7
to
7da8e3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposed implementation for this question because we wanted to use navindexes in repeats as well.
http://discuss.orbeon.com/Tabindex-in-repeating-region-help-td44715.html
Tabindex attributes are still copied to the HTML output (if there is no navindex attribute), but do not support AVTs.
This patch probably needs some cleanup and rework:
=> The method name addExtensionAttributesExceptClassAndAcceptForHandler doesn't reflect its behavior anymore. The extra check to exclude the navindex attribute was needed, because otherwise the control's span element received a navindex attribute. It needs to processed when sending an ajax response however (in addExtensionAttributesExceptClassAndAcceptForAjax)
=> Not sure if this is the way to change the tabindex attribute of a child. We couldn't find another example of an ajax response that set an attribute on a child HTML-element of the control. We also tried to specify the ID of the child-element in the server, but couldn't find an example of that either. This code also does the translation from navindex to tabindex in Javascript, which might not be desirable as well.