This repository has been archived by the owner on Sep 30, 2023. It is now read-only.
onEmpty -> onIdle #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes a mistake i made in #85
As seen here https://github.com/sindresorhus/p-queue#onempty and comparing onEmpty and onIdle:
.onEmpty will resolve when the queue is emptied, or when the last promise in the queue has been called.
.onIdle will resolve when the queue is completely done, or when the last promise in the queue has been called and has resolved.
.onIdle is the behavior I thought .onEmpty had but recently I looked at p-queue again and saw the difference.
the issue with using onEmpty here is we could still see some errors it was brought into prevent. onIdle would cover these cases where orbitdb closes the cache before the last _addOperation call in queue has resolved.
This pr changes the
await this._opqueue.onEmpty()line in the close method toawait this._opqueue.onIdle()so that the store does not close until the queue is emptied and all _addOperations are resolved.