This repository has been archived by the owner on Sep 30, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 11
refactor: update deps, add tests, make more lightweight #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphelionz
commented
Apr 19, 2020
You are a hero 🙌 |
Opted not to re-export
I'm only testing with
|
|
aphelionz
commented
Apr 22, 2020
aphelionz
commented
Apr 22, 2020
Ran into an error after
|
This was referenced Apr 22, 2020
Closed
aphelionz
force-pushed
the
refactor-update-deps
branch
from
April 29, 2020 17:45
396a426
to
1a2a3e9
Compare
aphelionz
force-pushed
the
refactor-update-deps
branch
4 times, most recently
from
May 11, 2020 00:43
f37d39c
to
0034ad9
Compare
Co-authored-by: tabcat <[email protected]>
aphelionz
force-pushed
the
refactor-update-deps
branch
from
May 11, 2020 00:58
bdf3560
to
9324b42
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates:
go-ipfs-dep
to~0.5.0
ipfs
to~0.43.0
ipfs-repo
to^1.0.1
ipfsd-ctl
to^3.1.0
Also, updating
ipfsd-ctl
allowed me to (at least attempt to) clean up this a bit. Iremovedcreated a factory object with preferred configuration fromstartIpfs
andstopIpfs
ipfsd-ctl
. I extended the prototype to create two new functions to the factory:spawnApi
to deal with the simple boilerplate of:localCluster
, which is where the real magic [can] happen, which takes an array of ipfs types likejs
,go
,proc
, etc, connects them all via permutation, and then returns the array of connected nodes.It will take refactoring the downstream tests a but but I believe this gives us a few advantages:
js
andgo
nodes in the same tests, while also still being able to loop through['js', 'go']
in our tests like we usually do, if we want. Note that we can also still usewaitForPeers
, andconnectPeers
.factory.clean()
method in theafter
methods in our mocha tests to properly clean up all the spawned daemons and not run into any more issues where the process doesn't close.Less code overall,Tradeoffs
Thetaken care of 🎉ipfsd-cts
exports someipfsd
object, where the object we really want itipfsd.api
. Just an extra thing but I couldn't find a place to really return that properly to keep things consistent.implementations
business to be dealt with, see my self-review comments below.TODO if/when approved
process.env.TEST
support0.9.0
Add CImoved to another PRnpm install
time onmaster
(Thinkpad W540, 8 cores, 24GB ram)real 1m32.161s
user 1m26.220s
sys 0m11.440s
Code coverage: