Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Windows support with the least possible number of changes, unlike other PRs with the same objective, this changes try to be friendly with the current code.
This is a summary of the most important changes:
cpy-cli
andmkdirp
were added to be alternatives to thecp
andmkdir
commands found in thepackage.json
scripts. Viewcross-env
library was added to execute thetest
command on all platforms.path.join
(orbit addresses) were changed to(path.posix || path)
. posix provides the correct way to join the strings and if it does not exist (in case of use on website) the normalpath
is used.join
has been created in theOrbitDBAddress
class that allows to replacepath.join
for the purpose of the previous point. ViewLOG
andLOCK
files fromtests/fixtures
, a small filter has been created to avoid copying these files. Viewtests/fixtures
when they have been saved with EOL: CRLF, this causes 4 tests to fail, the solution is to prevent git from changing the EOL of the files. Sourceload v0 orbitdb address
test fails most of the time (but not always) when it is first executed with thetest:all
command, if the test is run individually it passes without problems. I have calleddb.load()
before each test to correct this problem, however it is not a real solution.