Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Jenkinsfile #153

Closed
wants to merge 6 commits into from
Closed

Create Jenkinsfile #153

wants to merge 6 commits into from

Conversation

victorb
Copy link
Member

@victorb victorb commented Nov 20, 2017

Currently this repository is failing on jenkins with

Uncaught OpenError: IO error: c:\jenkins\workspace\IPFS_js-ipfs-repo_PR-153-GUNUWVWGXGOB3KKWNXV3RHGXDIAP7QRQCZS2QYQWYXCUFAQYJ6XQ\test\test-repo-for-1511171442216\datastore/MANIFEST-000052
: The filename, directory name, or volume label syntax is incorrect.

Error can be seen here: https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fjs-ipfs-repo/detail/PR-153/2/pipeline

Doesn't seem to fail on AppVeyor so somewhere, something is different to make this fail on Jenkins and also hosted Windows VMs on EC2 and MacStadium vSphere cluster.

@ghost ghost assigned victorb Nov 20, 2017
@ghost ghost added the status/in-progress In progress label Nov 20, 2017
@victorb victorb mentioned this pull request Nov 20, 2017
@richardschneider
Copy link
Contributor

Well it looks the ncp has not finished or failed without an error. This is a basic file copy (recursive)!

Here's the code

ncp(testRepoPath, repoPath, cb)

@victorb
Copy link
Member Author

victorb commented Nov 20, 2017

@richardschneider In my mind, there is still a path issue somewhere as the file it's trying to open is this one:

c:\jenkins\workspace\IPFS_js-ipfs-repo_PR-153-GUNUWVWGXGOB3KKWNXV3RHGXDIAP7QRQCZS2QYQWYXCUFAQYJ6XQ\test\test-repo-for-1511171442216\datastore/MANIFEST-000052

It ends with /datastore\MANIFEST-000052 which seems wrong (mixing forward and back-slashes). How did you come to the conclusion that ncp is the culprint? Checked the readme (https://www.npmjs.com/package/ncp) and seems errors should be logged to stdout and/or ./ncp-debug.log but neither contains any output related to ncp.

@victorb
Copy link
Member Author

victorb commented Nov 20, 2017

btw, ncp doesn't seem to be maintained anymore and bunch of people are having issues with files not being copied when callback is being called, might be a good idea to migrate to a different library. Although, switching doesn't seem to fix the issue. Switched out ncp for recursive-copy and still hitting the same issue.

@ipfs ipfs deleted a comment from codecov bot Nov 20, 2017
@richardschneider
Copy link
Contributor

@victorbjelkholm Windows is forgiving, it will allow both forward and back slashes in a path!

I think its ncp because the 'before-hook` only does 2 things; copy files and then open the store.

@ipfs ipfs deleted a comment from codecov bot Nov 20, 2017
@richardschneider
Copy link
Contributor

Comments on the path C:\Windows\TEMP\test-repo-for-1511176584426\datastore/MANIFEST-000052

  • \windows\temp is interesting. Normally TMP is somewhere in user's path. Who are we logged-in as? What version of windows is running?
  • 151117 is the current date (ddmmyy). Why is date so far in the past?

@victorb
Copy link
Member Author

victorb commented Nov 20, 2017

\windows\temp is interesting. Normally TMP is somewhere in user's path. Who are we logged-in as? What version of windows is running?

Administrator

151117 is the current date (ddmmyy). Why is date so far in the past?

No idea, computer is reporting date as 11/20/2017 which seems correct. (new Date()).toISOString() in a node repl also reports 2017-11-20T11:50:08.869Z

@victorb
Copy link
Member Author

victorb commented Nov 20, 2017

@richardschneider tried creating a new user Victor with default permissions (for Windows Server 2016) and getting The filename, directory name, or volume label syntax is incorrect.po-for-1511179358576\datastore/MANIFEST-000052 instead now

@ipfs ipfs deleted a comment from codecov bot Nov 20, 2017
@richardschneider
Copy link
Contributor

From the last run, which lists the files in the temp repo, it now appears that at node_modules\levelup\lib\levelup.js:117:34 could be responsible,

@ipfs ipfs deleted a comment from codecov bot Nov 20, 2017
@ipfs ipfs deleted a comment from codecov bot Nov 20, 2017
@ipfs ipfs deleted a comment from codecov bot Nov 22, 2017
@victorb
Copy link
Member Author

victorb commented Nov 22, 2017

Solved with core.autocrlf input in git config, as otherwise git will rewrite line-endings and make the MANIFEST-000052 file corrupt. Opened new PR for CI updates: #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants