New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OOI inputs #36

Merged

valentina-s merged 23 commits into orcasound:main from Molkree:ooi-inputs

Aug 16, 2021

Member

Molkree commented Jul 24, 2021 •

edited

Loading

This adds input parameters to the OOI workflow/script. Most important are node, time start/end, segment length, but also output directory and NFFT (like in Orcasound).

~~Want to add some tests first (mainly for parsing inputs).~~ Tests included.

Part of #8 #9 #35 for the OOI side.

Molkree requested a review from valentina-s

July 24, 2021 16:55

Molkree added the enhancement label

Molkree changed the title ~~Ooi inputs~~ OOI inputs

Molkree force-pushed the ooi-inputs branch 2 times, most recently from 6fe9d61 to 612c6d5 Compare

July 26, 2021 21:03

Member Author

Molkree commented Jul 27, 2021 •

edited

Loading

I'm not sure why tests run so long, 5min43sec for 1min+5min+5min of data 🤔
But it works so I guess it's fine
P.S. I will investigate further why it takes so long.

Molkree marked this pull request as ready for review

July 27, 2021 15:54

This was referenced Jul 28, 2021

Allow selection of node #8

Open

Allow selection of time frame #9

Open

valentina-s reviewed

View reviewed changes

.github/workflows/ooi_processing.yml Outdated Show resolved Hide resolved

valentina-s reviewed

View reviewed changes

tests/test_ooi.py Show resolved Hide resolved

valentina-s reviewed

View reviewed changes

tests/test_spectrograms.py Show resolved Hide resolved

valentina-s reviewed

View reviewed changes

tests/test_spectrograms.py Outdated Show resolved Hide resolved

valentina-s reviewed

View reviewed changes

create_spectrogram.py Outdated Show resolved Hide resolved

valentina-s reviewed

View reviewed changes

ooi_processing.py Show resolved Hide resolved

Collaborator

valentina-s commented Aug 2, 2021

@Molkree PR looks good! I added a few comments inline.

Molkree added 13 commits

August 9, 2021 23:48


          Extract spectrogram name creation

56e12f1


          Modify OOI script to accept input parameters

76e258c


          Add some OOI workflow inputs (WIP)

711e108


          Fix spectrogram creation

ca2c677


          Update OOI workflow

2d28fb9


          Fix envs

a97b80d


          Fix spectrorgams path

201e083


          Test spectrogram creation

264addf


          Remove trailing whitespace

ceddc78


          Add tests to CI

ec8c75e


          Add OOI workflow tests

c5ce53b


          Fix argument types in tests

a30cd3e


          Fix test job name

5640c15

Molkree added 3 commits

August 9, 2021 23:49


          Remove Python 3.9 feature

eb96eea


          Sometimes you need comments to accepted SO answers

afbd671


          docs: clarify that segment_length can be float

27e017e

Molkree force-pushed the ooi-inputs branch from 8a24701 to 27e017e Compare

August 9, 2021 20:50

Molkree added 7 commits

August 9, 2021 23:54


          style: fix variable name

2dad0f6


          test: remove files between tests

e7bb52d


          test: check end_time before start_time

2dad2e0


          test(test_create_spec_name): non .wav files

2171bc3


          test(ooi): fix end_time before start_time

7e57628


          fix: small fixes for spectrogram saving

c102c04


          test(spectrograms): compare with examples

d0176de

valentina-s merged commit 3aab7a2 into orcasound:main

Molkree deleted the ooi-inputs branch

August 16, 2021 20:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels