Add menu bar buttons #4
Conversation
| import React from 'react' | ||
|
|
||
| class Taskbar extends React.Component { | ||
| clearMarkers() { |
There was a problem hiding this comment.
make this an arrow function as with onClick the "this" property changes this code doesn't throws any error for now but we will definitely be using the this property in these functions.
| clearMarkers() { | ||
| console.log('clearing markers') | ||
| } | ||
| addRaw() { |
There was a problem hiding this comment.
same here make it a arrow function.
| addRaw() { | ||
| console.log('Adding raw observations') | ||
| } | ||
| pull() { |
There was a problem hiding this comment.
make it a arrow function.
| pull() { | ||
| console.log('Pulling from google sheets') | ||
| } | ||
| refresh() { |
There was a problem hiding this comment.
make it a arrow function.
| refresh() { | ||
| console.log('Refreshing markers') | ||
| } | ||
| openSheet() { |
There was a problem hiding this comment.
make it a arrow function.
|
Also @ivanoats as we are on the recent version of react we should be using the best strategies that current version of react has, like we can use react-hooks to decouple our logic from our component we can use the power of custom hooks for that. Also about the css if we are planning to use react-material-ui in project we wont be requiring any external css files that fixes alignment and all in hacky ways. |
|
I agree - function components and hooks if possible. |
|
This PR needs to be closed, or refactored from a class based component to a functional / hooks style. |
|
Hi @ivanoats I would like to work on this issue. This PR does not incorporate react hooks, and it would be better if I open another PR for the issue #3 rather than trying to solve the merge conflicts. This would be my first time working on this repository, please let me know if there is anything that needs to kept in mind other than what have already been mentioned in all the contributing guidelines. |
No description provided.