Upgrade types for tests

tests/App/Components/SimpleShowValue.php

@@ -9,19 +9,11 @@
 
 class SimpleShowValue extends Component
 {
-    /**
-     * @var User
-     */
-    public $value;
-
     /**
      * Create a new component instance.
-     *
-     * @param mixed $value
      */
-    public function __construct($value)
+    public function __construct(public mixed $value)
     {
-        $this->value = $value;
     }
 
     /**

tests/App/Components/SimpleShowValueWithArguments.php

@@ -9,31 +9,12 @@
 
 class SimpleShowValueWithArguments extends Component
 {
-    /**
-     * @var mixed
-     */
-    public $value;
-
-    /**
-     * @var Application
-     */
-    public $application;
-
-    /**
-     * @var string
-     */
-    public $from;
-
     /**
      * Create a new component instance.
-     *
-     * @param mixed $value
      */
-    public function __construct(Application $application, $value, string $from = 'Alexandr')
+    public function __construct(public Application $application, public mixed $value, public string $from = 'Alexandr')
     {
-        $this->value = $value;
-        $this->application = $application;
-        $this->from = $from;
+
     }
 
     /**

tests/App/Layouts/DependentSumListener.php

@@ -57,7 +57,7 @@ protected function layouts(): array
      */
     public function getSlug(): string
     {
-        return sha1($this->slug);
+        return sha1((string) $this->slug);
     }
 
     /**

tests/App/Notifications/TaskCompleted.php

@@ -16,10 +16,8 @@ class TaskCompleted extends Notification
 
     /**
      * Get the notification's delivery channels.
-     *
-     * @param mixed $notifiable
      */
-    public function via($notifiable): array
+    public function via(mixed $notifiable): array
     {
         return [DashboardChannel::class];
     }
@@ -35,10 +33,8 @@ public function toDashboard($notifiable): DashboardMessage
 
     /**
      * Get the array representation of the notification.
-     *
-     * @param mixed $notifiable
      */
-    public function toArray($notifiable): array
+    public function toArray(mixed $notifiable): array
     {
         return [
             //

tests/App/RouteSolving.php

@@ -30,7 +30,7 @@ public function resolveChildRouteBinding($childType, $value, $field)
     /**
      * @return string
      */
-    public function __toString()
+    public function __toString(): string
     {
         return 'Hello Word';
     }

tests/App/Screens/SerializeRetrievableScreen.php

@@ -19,9 +19,7 @@ public function __construct(
         private readonly string $private = 'Private',
         public $user = null
     ) {
-        $this->middleware(function ($request, $next) {
-            return $next($request);
-        });
+        $this->middleware(fn($request, $next) => $next($request));
     }
 
     /**

tests/App/Screens/SerializeScreen.php

@@ -16,9 +16,7 @@ public function __construct(
         private readonly string $private = 'Private',
         public $user = null
     ) {
-        $this->middleware(function ($request, $next) {
-            return $next($request);
-        });
+        $this->middleware(fn($request, $next) => $next($request));
     }
 
     /**

tests/Feature/App/RouteResolveScreenTest.php

@@ -95,9 +95,7 @@ public function testExplicitBinding(): void
 
     public function testResolutionLogic(): void
     {
-        Route::bind('user', function ($value) {
-            return User::where('email', $value)->firstOrFail();
-        });
+        Route::bind('user', fn($value) => User::where('email', $value)->firstOrFail());
 
         Route::screen('bind/users/{user}', ModelRouteBindScreen::class)
             ->middleware(config('platform.middleware.private'))

tests/Feature/Platform/RelationsTest.php

@@ -44,12 +44,10 @@ public function testScopeModel(array $scope): void
     {
         $response = $this->getScope($scope);
 
-        $json = $this->users->map(function ($user) {
-            return [
-                'value' => $user->id,
-                'label' => $user->email,
-            ];
-        })->toArray();
+        $json = $this->users->map(fn($user) => [
+            'value' => $user->id,
+            'label' => $user->email,
+        ])->toArray();
 
         $response->assertJson($json);
     }
@@ -63,12 +61,10 @@ public function testAppendModel(array $scope): void
     {
         $response = $this->getScope($scope, 'full');
 
-        $json = $this->users->map(function ($user) {
-            return [
-                'value' => $user->id,
-                'label' => $user->name.' ('.$user->email.')',
-            ];
-        })->toArray();
+        $json = $this->users->map(fn($user) => [
+            'value' => $user->id,
+            'label' => $user->name.' ('.$user->email.')',
+        ])->toArray();
 
         $response->assertJson($json);
     }

tests/Unit/FieldTest.php

@@ -113,13 +113,11 @@ public static function exampleFields(): ?\Generator
     }
 
     /**
-     * @param mixed $options
      *
      * @dataProvider exampleFields
-     *
      * @throws \Throwable
      */
-    public function testHasCorrectInstance(string $field, $options): void
+    public function testHasCorrectInstance(string $field, mixed $options): void
     {
         /** @var \Orchid\Screen\Field $field */
         $field = $field::make();

tests/Unit/Screen/Fields/RelationTest.php

@@ -80,7 +80,7 @@ public function testInstanceArrayWithStringPrimary(): void
 
         $select = Relation::make('role')
             ->title('Select roles')
-            ->fromModel(get_class(new $stringPrimaryClass), 'name')
+            ->fromModel($stringPrimaryClass::class, 'name')
             ->value($current->getRoleSlug());
 
         $view = self::renderField($select);

tests/Unit/Screen/Fields/RelationWithEnumTest.php

@@ -84,7 +84,7 @@ public function testInstanceArrayWithStringPrimary(): void
 
         $select = Relation::make('role')
             ->title('Select roles')
-            ->fromModel(get_class(new $stringPrimaryClass), 'name')
+            ->fromModel($stringPrimaryClass::class, 'name')
             ->value($current->getRoleSlug());
 
         $view = self::renderField($select);