Refactor: Reduce iter complexity in header_stats
#325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Moved the `sorted_by` operation after the map, saving space in the intermediate vector that `sorted_by` builds. 2. Replaced a `fold` operation with a straightforward `sum`. 3. Utilized `zip` to calculate `jtr`, reducing the need for an additional `get` step.
|
Hi @orf, It's me again. I believe this PR is easy to review. Please let me know if this kind of refactoring is annoying. I do it because I spend some time reading open-source code every day and I'll have some ideas about the code I read. |
|
Hey @TieWay59, thank you for this! I don't think it's annoying - I think it's great! So please if you spot any more chances to make things better then don't hesitate to drop an issue or open a pull request! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR did three change:
sorted_byoperation after the map, saving space in the intermediate vector thatsorted_bybuilds.foldoperation with a straightforwardsum.zipto calculatejtr, reducing the need for an additionalgetstep.