BeforeTestRun BoDi Dependency Injection bug?

[bethly-hallows]

Hi All,

I have recently picked up investigating migrating our test projects from Specflow to Reqnroll but have happened upon an issue, and unsure if this is a known issue/bug or if I am simply missing something. As this is a new project I figured this would be the best place to ask!

When using Specflow, I am able to register dependencies in the [BeforeTestRun] hook, as below. Here, I am just registering an instance of my test settings, as an example:

Then, say I want to use the test settings in a [BeforeScenario] hook, I am able to inject them via a constructor:

This method I have used time and time again, with no issue with the constructor happily injecting that dependency for me from within that container instance:

Here is the issue.... when I migrate to Reqnroll (with absolutely no other changes except the package and Using reference), the container instance does not seem to carry over to the [BeforeScenario] hooks!

I discovered the issue in an existing test project with many dependencies, but have replicated it on a brand new Reqnroll project with the test settings for ease.

Here are my project files with Specflow and with Reqnroll, for reference:

Would appreciate any thoughts on this, in the existing test project we have been doing it this way for years and the migration documentation didn't mention anything differently regarding DI.

[ajeckmans]

If you want to remain test framework independent you should not create a dependency between BeforeTestrun and BeforeScenario as they're not guaranteed to run in the same thread. Just a note of warning as I don't think this approach will work with all test runners.

Other than that I remember something in the documentation hinting at this not being a supported approach, but I can't find it anymore. Either I'm mistaken or the warning was removed at some point in the last two years.

This is touching on some work that I'm doing to make it possible to resolve scenario specific value retrievers, which also means properly keeping track of the container across the various hooks. That change is a bit slow going as I do have some time I can spend at work on it, but it has been given low priority unfortunately. I'll keep in mind to test this scenario as well if it is not resolved before then :)

[bethly-hallows]

@ajeckmans brilliant, I don't know why I couldn't find that and the related issue when doing my searches! Thankyou so much for your help :)

[gasparnagy]

@ajeckmans The challenge is that we have made a breaking change by touching the BoDi dependency (#80), so if we would release right now, that would need to be v2.0.0. Or we cherry pick all other fixes and release it as v1.1.0. Since this has a workaround, I would vote for fixing #56 , #71 and #81 first and then release a v2.

[bethly-hallows]

Hi @gasparnagy, I saw on another thread that a new release is impending- was just wondering if it got decided if the above was going to be in it, or if not, if there's any idea of a time frame for the above?

[gasparnagy]

@bethly-hallows yes, this is in. I'm currently preparing the release. And plan to have it (at least a preview) by tomorrow.

[gasparnagy]

It is out: https://github.com/orgs/reqnroll/discussions/142

closing this topic