Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): add 'gruvbox-light' theme #32

Merged
merged 7 commits into from
Jun 22, 2024

Conversation

mertssmnoglu
Copy link
Contributor

@mertssmnoglu mertssmnoglu commented Jun 20, 2024

Description of change

I heard that flawz need some more themes #6. I tried something to implement a Vim Light Theme called gruvbox-light It's NOT EXACT SAME but it's looks like gruvbox-light.

How has this been tested?

It can only be tested with the eyes. Testing in daylight is recommended.

Color Palette of gruvbox-light

gruvbox-light color palette


If we can agree on theme colors, I will add them too.

@mertssmnoglu mertssmnoglu requested a review from orhun as a code owner June 20, 2024 21:50
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I like it.

Can you also update README.md with a screenshot too?

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 7.84%. Comparing base (6698b7c) to head (68f3b6c).

Files Patch % Lines
src/theme.rs 0.00% 27 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #32      +/-   ##
========================================
- Coverage   8.14%   7.84%   -0.30%     
========================================
  Files         13      13              
  Lines        712     739      +27     
========================================
  Hits          58      58              
- Misses       654     681      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* bg='#EBDBB2'
* fg='#9D0006'
* upload theme preview png (1890x1007)
@mertssmnoglu
Copy link
Contributor Author

I changed the colors of the selected line so that it can be highlighted more easily.

Also updated README.md with theme preview. Other previews are 1000x600 but I couldn't take the screenshot at the same resolution.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the screenshot with the same resolution :)

Thanks for the contribution!

@orhun orhun changed the title New gruvbox-light theme feat(theme): add 'gruvbox-light' theme Jun 22, 2024
@orhun orhun merged commit af78e04 into orhun:main Jun 22, 2024
9 checks passed
@orhun orhun mentioned this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants