Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag parser seem to remove all "v" from version tags by default #18

Closed
jabdoa2 opened this issue Sep 27, 2021 · 3 comments
Closed

Tag parser seem to remove all "v" from version tags by default #18

jabdoa2 opened this issue Sep 27, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@jabdoa2
Copy link

jabdoa2 commented Sep 27, 2021

Describe the bug
In the Mission Pinball Framework we tag our commits as v0.56-dev.0 for development releases. Unfortunately, in git cliff those show up as 0.56-de.0 (notice the missing v).

Is there any guide how to change the tag regex? Standard perl syntax does not seem to work.

To Reproduce

  1. Tag a commit as ``v0.56-dev.0`
  2. Add some commits on top
  3. Run git cliff

Expected behavior
I would like cliff to show 0.56-dev.0 in the headline instead of 0.56-de.0.

Screenshots/Logs

## [0.56-de.0] - 2021-07-25
@jabdoa2 jabdoa2 added the bug Something isn't working label Sep 27, 2021
@orhun
Copy link
Owner

orhun commented Sep 27, 2021

Good catch! It is fixed in e444615. Default configuration removes only the leading "v" from the tag now.

This changes will be shipped with the upcoming release so feel free to try out and report bugs by either pulling the docker image or building from source.

Thank you for reporting this!

@jabdoa2
Copy link
Author

jabdoa2 commented Sep 27, 2021

Thanks!

@orhun
Copy link
Owner

orhun commented Oct 1, 2021

v0.4.0 is released now.

@orhun orhun closed this as completed Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants