Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert(args): update clap and clap extras to v4 (#137) #292

Merged
merged 2 commits into from
Sep 30, 2023
Merged

revert(args): update clap and clap extras to v4 (#137) #292

merged 2 commits into from
Sep 30, 2023

Conversation

joshka
Copy link
Contributor

@joshka joshka commented Sep 23, 2023

Description

This reverts commit 0e710c2.

Motivation and Context

This is to ensure that there is no GPL 3.0 code contributions left to
address #165

How Has This Been Tested?

This is an intermediate PR - the next one will effectively re-implement these changes

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@joshka
revert: feat(args): update clap and clap extras to v4 (orhun#137)
a18a41c 
This reverts commit 0e710c2.

This is to ensure that there is no GPL 3.0 code contributions left to
address orhun#165
@joshka joshka requested a review from orhun as a code owner September 23, 2023 20:37
@welcome
Copy link

welcome bot commented Sep 23, 2023

Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️

@joshka joshka mentioned this pull request Sep 23, 2023
Merged
12 tasks
@orhun orhun changed the title revert: feat(args): update clap and clap extras to v4 (#137) revert(args): update clap and clap extras to v4 (#137) Sep 30, 2023
@orhun orhun merged commit fb4c733 into orhun:main Sep 30, 2023
22 of 23 checks passed
@welcome
Copy link

welcome bot commented Sep 30, 2023

Congrats on merging your first pull request! ⛰️

@orhun orhun mentioned this pull request Sep 30, 2023
Closed
29 tasks
@p-linnane p-linnane mentioned this pull request Sep 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhun orhun orhun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshka @orhun