Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove GPL code #293

Merged
merged 3 commits into from
Sep 30, 2023
Merged

chore: remove GPL code #293

merged 3 commits into from
Sep 30, 2023

Conversation

joshka
Copy link
Contributor

@joshka joshka commented Sep 23, 2023 •
edited
Loading

Description

This reverts the changes in #292 which downgraded clap to v3 to remove the GPL code.

Motivation and Context

This is a clean upgrade to the latest version of clap that avoids the GPL licensed code changes in the previous commit.

How Has This Been Tested?

git-cliff -h produces the same output as cargo run -- -h

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@joshka
revert: feat(args): update clap and clap extras to v4 (orhun#137)
a18a41c 
This reverts commit 0e710c2.

This is to ensure that there is no GPL 3.0 code contributions left to
address orhun#165
@joshka joshka requested a review from orhun as a code owner September 23, 2023 20:40
@joshka joshka changed the title chore clap 4.4.4 Remove GPL code Sep 27, 2023
@orhun orhun changed the title Remove GPL code chore: remove GPL code Sep 30, 2023
@orhun orhun merged commit e3606ba into orhun:main Sep 30, 2023
22 of 23 checks passed
@orhun orhun mentioned this pull request Sep 30, 2023
Closed
29 tasks
@p-linnane p-linnane mentioned this pull request Sep 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orhun orhun orhun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshka @orhun