Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump does not work properly #343

Closed
o4rz3l opened this issue Nov 7, 2023 · 5 comments
Closed

Bump does not work properly #343

o4rz3l opened this issue Nov 7, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@o4rz3l
Copy link

o4rz3l commented Nov 7, 2023

Describe the bug

Bump does not reliably bump the version e.g. for a minor change ( feat: ) .In addition sometimes it produces "null" as next version (but i have not found a way to reproduce it).

BTW Just an idea: git cliff --bump --unreleased should offer to create the tag "v0.0.1" if no tag is set before.
To reproduce

Expected behavior

It should be bumped to 0.1.0.

Screenshots / Logs

image

Software information

  • Operating system: Win10 as well as WSL2
  • Project version: git-cliff 1.4.0
@o4rz3l o4rz3l added the bug Something isn't working label Nov 7, 2023
Copy link

welcome bot commented Nov 7, 2023

Thanks for opening your first issue at git-cliff! Be sure to follow the issue template! ⛰️

@orhun
Copy link
Owner

orhun commented Nov 7, 2023

Hello, thanks for reporting this!

git cliff --bump --unreleased should offer to create the tag "v0.0.1" if no tag is set before.

Created #344

It should be bumped to 0.1.0.

Not sure what happened there, maybe ping @MarcoIeni who is the author of next_version.

@MarcoIeni
Copy link
Sponsor Contributor

MarcoIeni commented Nov 8, 2023

It should be bumped to 0.1.0.

This is not how the next_version library works. I clarified it in MarcoIeni/release-plz#1064

Just an idea: git cliff --bump --unreleased should offer to create the tag "v0.0.1" if no tag is set before.

In rust, cargo new defaults to 0.1.0. Just FYI, it's up to Orhun to pick the right default!

@orhun
Copy link
Owner

orhun commented Nov 9, 2023

I think this behavior is fine as long as it is documented in git-cliff as well, does anyone volunteer to add that?

@orhun
Copy link
Owner

orhun commented Dec 31, 2023

The behavior has changed to support this use case in 4eef684

@orhun orhun closed this as completed Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants