Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split_commits with new lines create duplicate entries #606

Closed
1 task done
AntoineGS opened this issue Apr 11, 2024 · 1 comment · Fixed by #608
Closed
1 task done

split_commits with new lines create duplicate entries #606

AntoineGS opened this issue Apr 11, 2024 · 1 comment · Fixed by #608
Assignees
Labels
bug Something isn't working

Comments

@AntoineGS
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description of the bug

When using split commits, if there is a an empty line between commits, it will duplicate the commit prior to the empty line, and I noticed that it will sometimes assign it to a different scope, though I have not investigated the why at this point.
One of the reasons this is a problem is that in certain GUIs (like GitHub Desktop) if you enter the first line in the header and the second line in the body, it will automatically add a new line.

Steps To Reproduce

Simply editing the test from changelog.rs to contain a new line in one of the commits as such:
image
will create a duplicated entry:
image

Expected behavior

No duplication in the output (we could ignore empty lines as an easy fix when using split commits?)

Screenshots / Logs

No response

Software information

  • Operating system: Windows 10
  • Rust version: 1.79
  • Project version: tested with 2.2.1 and 2.1.2 and master branch

Additional context

I would like to undertake the changes, but wanted to discuss it first in case a different approach is preferred!
Thank you!

@AntoineGS AntoineGS added the bug Something isn't working label Apr 11, 2024
Copy link

welcome bot commented Apr 11, 2024

Thanks for opening your first issue at git-cliff! Be sure to follow the issue template! ⛰️

@AntoineGS AntoineGS changed the title split_commits with new lines creates duplicates split_commits with new lines create duplicate entries Apr 11, 2024
AntoineGS added a commit to AntoineGS/git-cliff that referenced this issue Apr 12, 2024
AntoineGS added a commit to AntoineGS/git-cliff that referenced this issue Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants