-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(commit): trim the trailing newline from message #403
fix(commit): trim the trailing newline from message #403
Conversation
Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️ |
Hey, thanks for the PR! 🐻 Do you think this might have side effects? It should be backwards compatible I reckon. Also, looks like the formatting job has failed, can you run |
When the commit message ends with a '\n', then it is not considered a valid conventional commit. That's why the message must be cleaned up.
6e386a0
to
8084d09
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
=======================================
Coverage 42.90% 42.90%
=======================================
Files 13 13
Lines 690 690
=======================================
Hits 296 296
Misses 394 394
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
no side effects, i think. 'cargo fmt' is ok. i rebased branch also. PR is up to date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Congrats on merging your first pull request! ⛰️ |
nice work! |
When the commit message ends with a '\n', then it is not considered a valid conventional commit. That's why the message must be cleaned up.
Description and Motivation and Context
Wrong next version when using the bumped-version parameter. The 'git commit' command creates a '\n' at the end of the line.
In this case, commit is considered as a patch.
https://github.com/MarcoIeni/release-plz/blob/4b0684ff8d9048032167a43fd70b70af4940239d/crates/next_version/src/next_version.rs#L27
How Has This Been Tested?
git cli command on linux/macos
Screenshots / Logs (if applicable)
Types of Changes
Checklist: