Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(changelog): add link_parsers for parsing/extracting links #42

Merged
merged 4 commits into from
Dec 31, 2021

Conversation

bachp
Copy link
Contributor

@bachp bachp commented Dec 17, 2021

Description

Allow parsing and extraction of links in commit messages.

Motivation and Context

See #41

How Has This Been Tested?

Added unit and integration tests.

I also tested it against the history of an internal project.

Screenshots / Output (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bachp bachp requested a review from orhun as a code owner December 17, 2021 22:12
Searches for patterns in commite messages and allows to convert them into
links via regular expression replacement.

This allows to include links to issue trackers and other tools in the resulting
changelog.

Closes orhun#41
@bachp bachp changed the title feat: add link_parsing feat: add link parsing Dec 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2021

Codecov Report

Merging #42 (6f748b0) into main (d23cf22) will increase coverage by 3.46%.
The diff coverage is 77.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   38.35%   41.81%   +3.46%     
==========================================
  Files          13       13              
  Lines         738      811      +73     
  Branches      196      207      +11     
==========================================
+ Hits          283      339      +56     
- Misses        357      364       +7     
- Partials       98      108      +10     
Impacted Files Coverage Δ
git-cliff-core/src/config.rs 24.45% <0.00%> (-3.05%) ⬇️
git-cliff/src/changelog.rs 73.78% <ø> (-1.79%) ⬇️
git-cliff-core/src/commit.rs 73.22% <83.61%> (+6.86%) ⬆️
git-cliff-core/src/repo.rs 29.90% <0.00%> (+2.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d23cf22...6f748b0. Read the comment docs.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 💯 Thanks for implementing this! 🐻

@orhun orhun changed the title feat: add link parsing feat(changelog): add link_parsers for parsing/extracting links Dec 31, 2021
@orhun orhun merged commit b88e7d3 into orhun:main Dec 31, 2021
@bachp bachp deleted the link-parser branch December 31, 2021 18:15
@GoMino
Copy link

GoMino commented Feb 10, 2022

Can we have a new release embedding this feature ?

The current version 0.5.0 was release before this merge

@orhun
Copy link
Owner

orhun commented Feb 12, 2022

Can we have a new release embedding this feature ?

The current version 0.5.0 was release before this merge

Sure, I had a release planned today. Will be out in a couple of hours.

@orhun
Copy link
Owner

orhun commented Feb 12, 2022

Can we have a new release embedding this feature ?

The current version 0.5.0 was release before this merge

v0.6.0 is out! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants