docs(website): improve matching gitmoji tip #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emojis are hard. The pattern was not matching the recycling emoji, for some reason.
Adding the variation selector`u{FE0F}` fixes it.
Further, this makes the zero-width joiner (`u{200D}`) optional, matching emojis both with and without the ZWJ.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
=======================================
Coverage 41.30% 41.30%
=======================================
Files 15 15
Lines 1034 1034
=======================================
Hits 427 427
Misses 607 607
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Emojis are hard. The pattern was not matching the certain emojis.
The new pattern fixes the issue by adding the variation selector
u{FE0F}.Further, this makes the zero-width joiner (
u{200D}) optional, matching emojis both with and without the ZWJ.How Has This Been Tested?
I tested the new pattern on my repo and found out many commits had been skipped: welpo/tabi@1bb3c91
Types of Changes