Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(example): use full links in GitHub templates #503

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

orhun
Copy link
Owner

@orhun orhun commented Feb 17, 2024

Description

Use full PR links in the changelog that is generated from GitHub templates

Motivation and Context

closes #487

How Has This Been Tested?

-

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd5e4d2) 41.30% compared to head (6126473) 41.30%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #503   +/-   ##
=======================================
  Coverage   41.30%   41.30%           
=======================================
  Files          15       15           
  Lines        1034     1034           
=======================================
  Hits          427      427           
  Misses        607      607           
Flag Coverage Δ
unit-tests 41.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun orhun merged commit a521891 into main Feb 17, 2024
41 of 42 checks passed
@orhun orhun deleted the chore/add_links_to_github_templates branch February 17, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github changelog template doesn't use full issue # and pull request # url links.
2 participants