-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(lib): clean up some code #709
Conversation
Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️ |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #709 +/- ##
==========================================
+ Coverage 36.66% 37.04% +0.38%
==========================================
Files 20 20
Lines 1544 1531 -13
==========================================
+ Hits 566 567 +1
+ Misses 978 964 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! It mostly looks good, the behavior looks like the same. I have some concerns about lib.rs
but will double check to make sure.
Co-authored-by: Orhun Parmaksız <[email protected]>
@orhun should be good now 🙏 |
Congrats on merging your first pull request! ⛰️ |
Awesome work, thanks a lot! |
Description
Some clean up opportunities I found while reading the code.
No functional changes intended.
Please let me know if breaking changes are a concern for you, I can revert the change to the public API in the core crate.
Motivation and Context
Refactor
How Has This Been Tested?
cargo test
+cargo clippy
Screenshots / Logs (if applicable)
Types of Changes
Checklist: