forked from pixie-io/pixie
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Support 64 bit B3 traceIDs in OTel exporter
Summary: OTel wants all trace ids to be 128bit. However b3 trace ids can be 64 bit. See https://github.com/openzipkin/b3-propagation#traceid-1 So we should also support propagating 64 bit trace IDs. To ensure compatibility with other OTel tooling, we left pad the trace IDs with zeroes and make it a 128 bit ID before passing it to the OTel endpoint. This mirrors the approach taken by open-telemetry/opentelemetry-go#698 Test Plan: Updated a test to use 64 bit trace ids and ensured that they get left padded with zeroes as expexted. Reviewers: nserrino, michelle, philkuz Reviewed By: philkuz JIRA Issues: PP-3407 Signed-off-by: Vihang Mehta <[email protected]> Differential Revision: https://phab.corp.pixielabs.ai/D11450 GitOrigin-RevId: 9f09a7e
- Loading branch information
Showing
2 changed files
with
17 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters