Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added record-style setter for zoneId #170

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Added record-style setter for zoneId #170

merged 3 commits into from
Aug 8, 2024

Conversation

jmigueprieto
Copy link
Member

@jmigueprieto jmigueprieto commented Aug 8, 2024 •
edited
Loading

Follow up of #169 (fixes inconsistencies in that PR)

  • Added builder/record-style setter zoneId("PST") for consistency.
  • Other setter return type should be void.
  • Added zoneId in equals, hashCode and toString.

@jmigueprieto
Added builder style setter for zoneId.
11fa3d8 
Added zoneId in equals, hashCode and toString
@jmigueprieto jmigueprieto self-assigned this Aug 8, 2024
@jmigueprieto jmigueprieto changed the title Added builder-style setter for zoneId Added record-style setter for zoneId Aug 8, 2024
@jmigueprieto jmigueprieto merged commit 65832de into main Aug 8, 2024
2 checks passed
@jmigueprieto jmigueprieto deleted the fix/schedule_zone_id_field branch August 8, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c4lm c4lm c4lm approved these changes

@manan164 manan164 Awaiting requested review from manan164

@v1r3n v1r3n Awaiting requested review from v1r3n

Assignees

@jmigueprieto jmigueprieto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmigueprieto @c4lm