Skip to content

Commit

Permalink
fix: remove npm ci
Browse files Browse the repository at this point in the history
  • Loading branch information
@jonalan7
jonalan7 committed Jul 25, 2023
1 parent dc52d4a commit 8db4b93
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
restore-keys: ${{ runner.os }}-node-

- name: Install dependencies
run: npm ci
run: npm install

- name: Build source code
run: npm run build
run: npm run build
4 changes: 3 additions & 1 deletion .gitignore
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,6 @@ session-*
src/app.ts
tokens
chrome
.env
.env
package-lock.json
yarn.lock

3 comments on commit 8db4b93

@maico910
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are changing npm ci to npm install? and Imo shouldn't add lock files in gitignore

@jonalan7
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the npm install command is the appropriate choice for this GitHub Actions task. npm ci is most recommended in production or continuous integration scenarios.

@jonalan7
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

including package-lock.json and yarn.lock in .gitignore allows project developers to install as dependencies based on locally generated lock files, ensuring consistency and avoiding unnecessary conflicts in version control files.

Please sign in to comment.