Spring cleaning #239

duckies · 2021-08-09T00:38:09Z

No description provided.

Account creation logic was refactored so it only needs to check if the primary account user was created pre-verified. Sending the email after account creation also prevents emails being sent on conflict.

This will be necessary for catching error reasons for features such as PayPal.

… (wip)

codecov-commenter · 2021-08-09T00:41:16Z

Codecov Report

Merging #239 (fef0e39) into dev (8a01903) will decrease coverage by 3.34%.
The diff coverage is 31.11%.

❗ Current head fef0e39 differs from pull request most recent head 38dc976. Consider uploading reports for the commit 38dc976 to get more accurate results

@@            Coverage Diff             @@
##              dev     #239      +/-   ##
==========================================
- Coverage   57.63%   54.29%   -3.35%     
==========================================
  Files         116      130      +14     
  Lines        2795     3144     +349     
  Branches      373      423      +50     
==========================================
+ Hits         1611     1707      +96     
- Misses       1177     1430     +253     
  Partials        7        7

Impacted Files	Coverage Δ
packages/server/src/app.module.ts	`0.00% <0.00%> (ø)`
packages/server/src/app.roles.ts	`100.00% <ø> (ø)`
...ges/server/src/attendance/attendance.controller.ts	`0.00% <0.00%> (ø)`
...ackages/server/src/attendance/attendance.module.ts	`0.00% <0.00%> (ø)`
...ckages/server/src/attendance/attendance.service.ts	`0.00% <0.00%> (ø)`
packages/server/src/invoice/invoice.controller.ts	`71.42% <0.00%> (+8.92%)`	⬆️
...ages/server/src/membership/membership.constants.ts	`0.00% <0.00%> (ø)`
...ges/server/src/membership/membership.controller.ts	`0.00% <0.00%> (ø)`
...ackages/server/src/membership/membership.module.ts	`0.00% <0.00%> (ø)`
...ckages/server/src/membership/membership.service.ts	`0.00% <0.00%> (ø)`
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ae8baf...38dc976. Read the comment docs.

duckies added 6 commits August 7, 2021 16:09

feat: warn of email conflicts on admin account creation

992399f

feat: send verification emails for admin created accounts

2f192f3

Account creation logic was refactored so it only needs to check if the primary account user was created pre-verified. Sending the email after account creation also prevents emails being sent on conflict.

feat: StateError includes response data if it exists

82127ce

This will be necessary for catching error reasons for features such as PayPal.

feat: support requiring verified emails in UserAuth decorator

42925c9

fix(server): prevent error when no auth flags are provided

ce162f6

chore: organize memberships to be more similar to event registrations…

fef0e39

… (wip)

duckies added 7 commits August 12, 2021 19:28

chore: upgrade dependencies

49f9a31

chore: minor code cleanup

7a12f98

feat: use metadata driven activity records

21cfe5c

fix: use America/New_York timezone when creating events

06fb44d

fix: global styles are used on admin layout, remove buggy color

99b9cfe

refactor: reference global styles in nuxt.config.ts

1ba85de

chore: incomplete changes

38dc976

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spring cleaning #239

Spring cleaning #239

duckies commented Aug 9, 2021

codecov-commenter commented Aug 9, 2021 •

edited by codecov bot

Loading

Spring cleaning #239

Are you sure you want to change the base?

Spring cleaning #239

Conversation

duckies commented Aug 9, 2021

codecov-commenter commented Aug 9, 2021 • edited by codecov bot Loading

Codecov Report

codecov-commenter commented Aug 9, 2021 •

edited by codecov bot

Loading