BUGFIX + Break Compatibility change: fix an issue with attributes no… #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… assigned to a family when the attributes has relations and its name is too long. The attribute code generated differ in AttributeImportStrategy and AttributeFamilyImportStrategy. It's a BC because on an existing installation, existing attributes may be duplicated with a different attribute code.
dxops
reviewed
Oct 14, 2019
There was a problem hiding this comment.
Hello @sylvainraye ,
thank you for your contribution, check my comments below, please
dxops
added a commit
that referenced
this pull request
Jan 8, 2020
… assigned to a family when the attributes has relations and its name is too long. The attribute code generated differ in AttributeImportStrategy and AttributeFamilyImportStrategy. It's a BC because on an existing installation, existing attributes may be duplicated with a different attribute code. Fixes #21 + BC layer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t assigned to a family when the attributes has relations and its name is too long. The attribute code generated differ in AttributeImportStrategy and AttributeFamilyImportStrategy. It's a BC because on an existing installation, existing attributes may be duplicated with a different attribute code.