-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the specs for re-relaying #1
Conversation
…ion/mutation/objectidentification spec
mutation fields in a standardized way. These mutations accept and emit a | ||
identifier string, which allows Relay to track mutations and responses. | ||
identifier string, which allows Relay Classic to track mutations and responses. | ||
|
||
All mutations may include in their input a `clientMutationId` string, which is | ||
then returned as part of the object returned by the mutation field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doc could probably stay in relay? it's only for relay classic now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
way. | ||
|
||
In the query, the connection model provides a standard mechanism for slicing | ||
and paginating the result set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a hard time understanding this sentence. I know you didn’t write this, but do you understand what it’s trying to convey?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's talking about always using the same args in each connection for pagination
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g. before
after
next
the_other_one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reading further, I think they mean in the literal query text, and then what you said yeah
Co-Authored-By: orta <[email protected]>
Co-Authored-By: orta <[email protected]>
Co-Authored-By: orta <[email protected]>
mutation fields in a standardized way. These mutations accept and emit a | ||
identifier string, which allows Relay to track mutations and responses. | ||
identifier string, which allows Relay Classic to track mutations and responses. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this was a stated intent for Modern, the identifier string (clientMutationId
) hasn't actually been removed yet. Nonetheless I'd leave this change in the upstream PR and then discuss it.
object identifiers in a standardized way. In the query, the schema should | ||
provide a standard mechanism for asking for an object by ID. In the response, | ||
the schema provides a standard way of providing these IDs. | ||
To provide options for GraphQL clients to elegantly handle for caching and data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is “to handle for” English?
I like adding the examples 👍
Co-Authored-By: orta <[email protected]>
No description provided.