Sort datasetconfig for deterministic storage #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpower432
reviewed
Sep 30, 2022
cli/build_collection.go
Outdated
| @@ -224,8 +225,15 @@ func (o *BuildCollectionOptions) Run(ctx context.Context) error { | |||
|
|
|||
| descs = append(descs, linkedDescs...) | |||
|
|
|||
| // Store the DataSetConfiguration file in the manifest config of the OCI artifact for | |||
| // later use. | |||
| // Sort the slices within the DataSetConfiguration and store the file | |||
There was a problem hiding this comment.
Can we move this logic to config/load? It would probably be useful to have these sorted upfront.
afflom
force-pushed
the
bug/build-determ
branch
from
741e4b0
to
d92a2ce
Compare
jpower432
reviewed
Oct 20, 2022
|
@afflom are you planning on adding the requested unit tests? |
|
Yes, but I'm finishing up the attributes API on the registry first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #92