fix: trying to bind to an outbound ip returns an empty list of port bindings #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzoum
force-pushed
the
fix.publicFacingIP
branch
from
430e259
to
52fd1c9
Compare
atzoum
force-pushed
the
fix.publicFacingIP
branch
from
52fd1c9
to
b88e120
Compare
Merged
1 task
atzoum
commented
Sep 23, 2024
| if err != nil { | ||
| return nil, err | ||
| } | ||
| const maxRetries = 10 |
There was a problem hiding this comment.
Note: you may verify the existence of the bug by setting maxRetries = 0
5 tasks
|
@aeneasr can you please review? |
alexandear
reviewed
Oct 15, 2024
go.mod
Outdated
| @@ -14,7 +14,7 @@ require ( | |||
| github.com/lib/pq v1.10.9 | |||
| github.com/moby/term v0.5.0 | |||
| github.com/opencontainers/image-spec v1.1.0 | |||
| github.com/opencontainers/runc v1.1.13 | |||
| github.com/opencontainers/runc v1.1.14 | |||
There was a problem hiding this comment.
I'm not sure we need upgrading runc version in this PR. It's the work for @dependabot (see #538)
There was a problem hiding this comment.
iirc a check was failing, shall I revert?
There was a problem hiding this comment.
@alexandear here is the failing check
https://github.com/ory/dockertest/actions/runs/11347631243/job/31559482556
There was a problem hiding this comment.
The maintainer merges #538 and the fail in this branch will be gone.
dockertest.go
Outdated
| for _, bindings := range c.NetworkSettings.Ports { | ||
| if len(bindings) == 0 { | ||
| time.Sleep(100 * time.Millisecond) | ||
| return d.inspectContainerWithRetries(id, retry+1) |
There was a problem hiding this comment.
Is it possible to avoid recursion?
atzoum
force-pushed
the
fix.publicFacingIP
branch
from
d0e025e
to
ba3a749
Compare
aeneasr
approved these changes
Nov 15, 2024
6 tasks
alexandear
reviewed
Nov 15, 2024
| }(); !hasEmptyPortBindings { | ||
| return c, nil | ||
| } | ||
| retryNum++ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep calling docker inspect with a short delay until all port bindings are properly populated.
Related Issue or Design Document
When trying to bind to an outbound interface, the first docker inspect call right after the container has been created doesn't return port bindings properly in the response. This causes an empty host/port to be calculated by the resource.
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments