Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oauth2: introspection handler excess calls #117

Closed
jrossiter opened this issue Oct 17, 2016 · 1 comment
Closed

oauth2: introspection handler excess calls #117

jrossiter opened this issue Oct 17, 2016 · 1 comment
Assignees
@aeneasr
Labels
bug Something is not working.

Comments

@jrossiter
Copy link
Contributor

jrossiter commented Oct 17, 2016 •
edited
Loading

I'm running a test server with all OAuth2 factories enabled.

In func (f *Fosite) IntrospectToken: len(f.TokenIntrospectionHandlers) returns 5 for the length.

Whenever a request for introspection comes in the same IntrospectToken() is run 5 times.
All validators return the same successful response.

Should these handler range loops return early when a non-error has been returned?
Is this a side effect of having the IntrospectToken function on the Fosite OAuth2Provider? (and therefore all factories implement introspection)
@aeneasr aeneasr added the bug Something is not working. label Oct 17, 2016
@aeneasr aeneasr self-assigned this Oct 17, 2016
@aeneasr
Copy link
Member

aeneasr commented Oct 17, 2016

Ah yes, that's an issue with the composer I think. Usually it shouldn't add duplicates but I think due to the composed types it isn't detecting them as dupes. Thanks for the report

aeneasr pushed a commit that referenced this issue Oct 17, 2016
all: resolve regression issues introduced by 0.6.0 - closes #118
3c11df5 
* oauth2: introspection handler excess calls - closes #117
* oauth2: inaccurate expires_in time - closes #72
aeneasr pushed a commit that referenced this issue Oct 17, 2016
all: resolve regression issues introduced by 0.6.0 - closes #118
7957b1f 
* oauth2: introspection handler excess calls - closes #117
* oauth2: inaccurate expires_in time - closes #72
aeneasr pushed a commit that referenced this issue Oct 17, 2016
all: resolve regression issues introduced by 0.6.0 - closes #118
0b64877 
* oauth2: introspection handler excess calls - closes #117
* oauth2: inaccurate expires_in time - closes #72
aeneasr pushed a commit that referenced this issue Oct 17, 2016
all: resolve regression issues introduced by 0.6.0 - closes #118
3dbdccc 
* oauth2: introspection handler excess calls - closes #117
* oauth2: inaccurate expires_in time - closes #72
aeneasr pushed a commit that referenced this issue Oct 17, 2016
all: resolve regression issues introduced by 0.6.0 - closes #118
a404a14 
* oauth2: introspection handler excess calls - closes #117
* oauth2: inaccurate expires_in time - closes #72
aeneasr pushed a commit that referenced this issue Oct 17, 2016
all: resolve regression issues introduced by 0.6.0 - closes #118
b8ce779 
* oauth2: introspection handler excess calls - closes #117
* oauth2: inaccurate expires_in time - closes #72
budougumi0617 added a commit to budougumi0617/fosite that referenced this issue May 10, 2019
@budougumi0617
0.5.0 (ory#119)
1a73ad6 
* all: resolve regression issues introduced by 0.4.0 - closes ory#118
* oauth2: introspection handler excess calls - closes ory#117
* oauth2: inaccurate expires_in time - closes ory#72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeneasr aeneasr

Labels
bug Something is not working.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aeneasr @jrossiter