Permit response_type be "code id_token" #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is PKCE defined for hybrid flows? |
|
Sorry for response so late.
When callback url was hijacked, PKCE can prevent from obtaining access token. The same thing can happen in hybrid flow and nothing else can prevent it.
I will push it soon. Thanks. |
Signed-off-by: Adam Shannon <[email protected]> Signed-off-by: Wenhao Ni <[email protected]>
Signed-off-by: Adam Shannon <[email protected]> Signed-off-by: Wenhao Ni <[email protected]>
Users of this library can easily create the following:
hasher := fosite.BCrypt{}
hasher.Hash(..)
This is a problem because WorkFactor will default to 0 and x/crypto/bcrypt will default that to 4 (See https://godoc.org/golang.org/x/crypto/bcrypt).
Instead this should be some higher cost factor. Callers who need a lower WorkFactor can still lower the cost, if needed.
Signed-off-by: Adam Shannon <[email protected]>
Signed-off-by: Wenhao Ni <[email protected]>
Signed-off-by: Wenhao Ni <[email protected]>
Signed-off-by: Wenhao Ni <[email protected]>
Signed-off-by: Wenhao Ni <[email protected]>
Signed-off-by: Wenhao Ni <[email protected]>
Signed-off-by: Wenhao Ni <[email protected]>
Signed-off-by: Wenhao Ni <[email protected]>
5 tasks
|
Thank you! |
budougumi0617
added a commit
to budougumi0617/fosite
that referenced
this pull request
May 10, 2019
Signed-off-by: Adam Shannon <[email protected]> Signed-off-by: Wenhao Ni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
None
Proposed changes
When hybrid flow with response_type=id_token code, we must permit code and others.
For that, I change the check method from Exact to Has.
Checklist
vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
by signing my commit(s). You can amend your signature to the most recent commit by using
git commit --amend -s. If youamend the commit, you might need to force push using
git push --force HEAD:<branch>. Please be very careful when usingforce push.
Further comments
None.