Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should set expires at for authorize code issued by hybrid flow #333

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

nerocrux
Copy link
Contributor

@nerocrux nerocrux commented Nov 7, 2018

Related issue

  • none

Proposed changes

  • Should set authorize code's expires_at, which is issued by hybrid flow.

Checklist

  • I have read the contributing guidelines
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • I signed the Developer's Certificate of Origin
    by signing my commit(s). You can amend your signature to the most recent commit by using git commit --amend -s. If you
    amend the commit, you might need to force push using git push --force HEAD:<branch>. Please be very careful when using
    force push.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)

Further comments

@nerocrux nerocrux force-pushed the fix/expires_at_auth_code_hybrid branch from 9bdc8e4 to 36cb79e Compare November 7, 2018 03:52
@aeneasr
Copy link
Member

aeneasr commented Nov 8, 2018

Thank you!

@aeneasr aeneasr merged commit d275e84 into ory:master Nov 8, 2018
budougumi0617 added a commit to budougumi0617/fosite that referenced this pull request May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants