Enable fosite composing with custom hashers. #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
reviewed
May 23, 2017
compose/compose.go
Outdated
| @@ -30,14 +30,17 @@ type Factory func(config *Config, storage interface{}, strategy interface{}) int | |||
| // ) | |||
| // | |||
| // Compose makes use of interface{} types in order to be able to handle a all types of stores, strategies and handlers. | |||
| func Compose(config *Config, storage interface{}, strategy interface{}, factories ...Factory) fosite.OAuth2Provider { | |||
| func Compose(config *Config, storage interface{}, strategy interface{}, hasher interface{}, factories ...Factory) fosite.OAuth2Provider { | |||
There was a problem hiding this comment.
Why is hasher an interface here? It's not being used apart from type asserting hasher.(fosite.Hasher)
There was a problem hiding this comment.
Good question! I was blindly copying the storage implementation. Fixed with latest commit.
aeneasr
added
the
stale
1 similar comment
Signed-off-by: Matthew Hartstonge <[email protected]>
matthewhartstonge
force-pushed
the
submit-custom-hasher-support
branch
from
f479865
to
eccc205
Compare
aeneasr
removed
the
stale
|
note to self: add this to breaking changes in history.md |
budougumi0617
added a commit
to budougumi0617/fosite
that referenced
this pull request
May 10, 2019
Signed-off-by: Matthew Hartstonge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it a little easier for composing, plus follows the same conventions as storage. Seeks to keep compatibility by setting BCrypt as the default hasher if one isn't set.
Signed-off-by: Matthew Hartstonge [email protected]