Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RefreshTokenScopes Config #371

Merged
merged 5 commits into from
Sep 16, 2019
Merged

Add RefreshTokenScopes Config #371

merged 5 commits into from
Sep 16, 2019

Conversation

dmcinnes
Copy link
Contributor

Related issue

Original discussion #370 discussed with @aeneasr

Proposed changes

This adds the RefreshTokenScopes to compose config to set which scopes will provide a refresh token on grant exchange. This defaults to "offline" and "offline_access". When empty all grant exchanges will provide a refresh token.

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)

Further comments

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2019

CLA assistant check
All committers have signed the CLA.

@aeneasr aeneasr self-assigned this Jul 2, 2019
@aeneasr aeneasr self-requested a review July 2, 2019 11:12
@aeneasr
Copy link
Member

aeneasr commented Jul 2, 2019

Could you please sign the CLA? :)

@dmcinnes
Copy link
Contributor Author

dmcinnes commented Jul 4, 2019 via email

@aeneasr
Copy link
Member

aeneasr commented Aug 12, 2019

Any updates? :)

@dmcinnes
Copy link
Contributor Author

Unfortunately still waiting on the last level of approval.

@dmcinnes
Copy link
Contributor Author

Hello @aeneasr, I've signed the CLA.

@aeneasr
Copy link
Member

aeneasr commented Sep 16, 2019

Thank you! Just came back from a vacation so sorry for the delay :)

@aeneasr aeneasr merged commit bcc7859 into ory:master Sep 16, 2019
@dmcinnes dmcinnes deleted the allow-refresh-tokens-config branch September 16, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants