fix: Not part of any interface #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thank you for your contribution! |
mitar
added a commit
to mitar/fosite
that referenced
this pull request
Apr 6, 2020
Followup to ory#417.
5 tasks
mitar
added a commit
to mitar/fosite
that referenced
this pull request
Apr 6, 2020
Followup to ory#417.
aeneasr
pushed a commit
that referenced
this pull request
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#346 Proposed changes
DeleteAuthorizeCodeSessionandCreateImplicitAccessTokenSessionnot part of any storage interface. So deleting them to not confuse people to think they have to implement them.Checklist
vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.